Skip to content

Commit

Permalink
Update lineage query function.
Browse files Browse the repository at this point in the history
  • Loading branch information
robertwb committed Dec 18, 2024
1 parent 71a5ced commit 14f7caf
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 4 deletions.
3 changes: 3 additions & 0 deletions sdks/python/apache_beam/metrics/cells.py
Original file line number Diff line number Diff line change
Expand Up @@ -811,6 +811,9 @@ def contains(self, value):
else:
return False

def flattened(self):
return self.as_trie().flattened()

def to_proto(self) -> metrics_pb2.BoundedTrie:
return metrics_pb2.BoundedTrie(
bound=self._bound,
Expand Down
12 changes: 8 additions & 4 deletions sdks/python/apache_beam/metrics/metric.py
Original file line number Diff line number Diff line change
Expand Up @@ -456,14 +456,18 @@ def add_raw(self, *rollup_segments: str) -> None:
self.metric.add(rollup_segments)

@staticmethod
def query(results: MetricResults, label: str) -> Set[str]:
def query(results: MetricResults,
label: str,
truncated_marker: str = '*') -> Set[str]:
if not label in Lineage._METRICS:
raise ValueError("Label {} does not exist for Lineage", label)
response = results.query(
MetricsFilter().with_namespace(Lineage.LINEAGE_NAMESPACE).with_name(
label))[MetricResults.STRINGSETS]
label))[MetricResults.BOUNDED_TRIES]
result = set()
for metric in response:
result.update(metric.committed)
result.update(metric.attempted)
for fqn in metric.committed.flattened():
result.add(''.join(fqn[:-1]) + (truncated_marker if fqn[-1] else ''))
for fqn in metric.attempted.flattened():
result.add(''.join(fqn[:-1]) + (truncated_marker if fqn[-1] else ''))
return result

0 comments on commit 14f7caf

Please sign in to comment.