GH-45015: [C++][Parquet] Allow configuring the default footer read size #45016
+13
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
lidavidm
approved these changes
Dec 13, 2024
github-actions
bot
added
awaiting merge
mapleFU
reviewed
Dec 13, 2024
raulcd
reviewed
Dec 13, 2024
github-actions
bot
added
awaiting changes
Co-authored-by: mwish <[email protected]>
github-actions
bot
added
awaiting change review
github-actions
bot
added
awaiting changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Reading the footer for a parquet file whose file metadata is >64KB can require multiple round trips to a high latency file system like S3. Allowing this default read size to be configurable allows for reducing the round trips if it's known up front that the file might potentially have a large amount of metadata.
What changes are included in this PR?
A
footer_read_size_property is added to parquetReaderPropertiesalong with a getter/setter. This is then utilized in the file reader'sGetFooterReadSizemethod.