Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-45005 [C++] Support for fixed-size list in conversion of range tuple #45008

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

GH-45005 [C++] Support for fixed-size list in conversion of range tuple #45008

wants to merge 2 commits into from

Conversation

mroz45
Copy link
Contributor

@mroz45 mroz45 commented Dec 12, 2024 •
edited by github-actions bot
Loading

What changes are included in this PR?

This PR introduces support for fixed-size lists in Apache Arrow's STL conversion. Added specializations for arrow::stl::ConversionTraits and arrow::CTypeTraits to handle std::array as a fixed-size list and also Unit Test.

Are these changes tested?

Yes, new type is tested.

Are there any user-facing changes?

@github-actions GitHub Actions
Copy link

⚠️ GitHub issue #45005 has been automatically assigned in GitHub to PR creator.

pitrou
pitrou requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @mroz45 . I think this is a good idea, can please address the following comments?

cpp/src/arrow/stl_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Outdated Show resolved Hide resolved
cpp/src/arrow/stl_test.cc Show resolved Hide resolved
@github-actions github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Dec 12, 2024
@mroz45
Copy link
Contributor Author

mroz45 commented Dec 12, 2024

Thanks for doing this @mroz45 . I think this is a good idea, can please address the following comments?

Is it looking good for now? @pitrou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapleFU mapleFU mapleFU left review comments

@pitrou pitrou pitrou requested changes

Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroz45 @pitrou @mapleFU