GH-44953: [R] Add R bindings for new compute functions #44971
Conversation
|
This PR branch is currently based on #44630 and I'll rebase and force-push once that's merged. I still need to:
|
amoeba
force-pushed
the
feature/GH-44953--r-compute-bindings
branch
from
de2ca98 to
dd01aae
Compare
r/NEWS.md
Outdated
| - Added missing dplyr binding for atan (#44953) | ||
| - Added bindings for hyperbolig trig functions sinh, cosh, tanh, asinh, acosh, and tanh (#44953) | ||
| - Added bindings for expm1 (#44953) |
There was a problem hiding this comment.
It doesn't really matter but I wonder if collapsing these into one bullet (since there's one issue) would be better?
There was a problem hiding this comment.
One bullet is fine, I'll change it.
| cosh = eval_array_expression("cosh", x), | ||
| sinh = eval_array_expression("sinh", x), | ||
| tanh = eval_array_expression("tanh", x), | ||
| acosh = eval_array_expression("acosh_checked", x), | ||
| asinh = eval_array_expression("asinh", x), | ||
| atanh = eval_array_expression("atanh_checked", x), |
There was a problem hiding this comment.
Mostly out of curiosity: did we miss these earlier? Or are they also new?
There was a problem hiding this comment.
They're new as of #44630 which hasn't been released.
github-actions
bot
added
awaiting merge
| @@ -15,6 +15,8 @@ | |||
| # specific language governing permissions and limitations | |||
| # under the License. | |||
|
|
|||
| source("../../extra-tests/helpers.R") | |||
There was a problem hiding this comment.
@jonkeane: I wanted to use skip_if_version_less_than so I did this but I think the tests can't rely on anything that's buildignored (like the extra-tests folder is). I think I'd prefer to move these helpers into ./tests and have the files in ./extra-tests pull that helper in. Any strong preference?
Rationale for this change
Adds R bindings to newly added hyperbolic trig and Expm1 compute functions. See #44953. Bindings prefer calling
_checkedvariants of compute functions where applicable which follows how existing bindings have been implemented.What changes are included in this PR?
base::atanAre these changes tested?
Yes.
Are there any user-facing changes?
New compute bindings in R.