GH-32381: [C++] Improve error handling for hash table merges #44969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Issue: #32381
Description
This pull request introduces a comprehensive test suite for the hash aggregation functionality in Apache Arrow’s compute kernels. The new test suite covers the following key components:
GroupedCountImpl:
GroupedMinMaxImpl:
GroupedCountAllImpl:
The test suite is structured following the conventions of aggregate_test.cc, providing comprehensive coverage of valid and edge-case scenarios.
Key Changes
New Test File: Added hash_aggregate_test.cc in cpp/src/arrow/compute/kernels/.
CMake Configuration: Updated cpp/src/arrow/compute/kernels/CMakeLists.txt to include the new test file.
Test Coverage:
Each test focuses on verifying correctness, error handling, and robustness for the Merge methods of:
Future Work
If this test suite is approved, I plan to extend similar coverage to the remaining hash aggregation classes, including:
This phased approach allows focused and iterative improvements to the test coverage for Arrow compute kernels.