-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-44314: [Packaging][Python] Use macOS 12 as deployment target to have macOS 12 pyarrow wheels #44315
Conversation
… to have macos 12 pyarrow wheels
|
@github-actions crossbow submit wheel-macos-monterey-*-amd64 |
This comment was marked as outdated.
This comment was marked as outdated.
Thanks @raulcd! |
@github-actions crossbow submit wheel-macos-monterey-*-amd64 |
Revision: f5f407a Submitted crossbow builds: ursacomputing/crossbow @ actions-bc85ef5cec |
Is there someone with a macOS 12 machine that can test (one of) the generated wheels? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Maybe @assignUser can spin up an AWS macOS 12 and just run the tests with one of those wheels? I don't have free access to an AWS account at the moment |
We should merge this to 18.0.0, would be nice if we can get a test @amoeba @assignUser maybe? |
Ideally we can indeed test this, but FWIW I think many projects build with an older deployment target than what they are testing with (given the limitations of free CI). We of course have the history of the macos-11 target actually failing in practice .. (#41696), because we were also not testing with it. But given it was working recently on CI, I assume running pyarrow on macos-12 is still fine. |
I don't have an amd64 macOS 12 machine laying around but I can probably find one. It sounds like it's not critical for this issue but I'll give it a try and report back. |
I was able to install the wheel on one of the deprecated macos-12 runners:
|
FWIW installing is not enough to actually test it (installing just depends on the tag in the wheel name), you will have to at least import pyarrow in a python session (for macos-11 importing was sufficient to trigger a segfault (#41696), but if there is a problem in one of the submodules, even importing is not enough) |
🤦 of course ... sorry I'll do that soon |
I successfully tested reading and writing parquet locally and reading from s3 and imported and used compute. So it should be fine. I do think in general it's ok to keep the deployment target at 12 until we get user reports that it doesn't work. We should probably note somewhere that eol macos support is best effort and can't be guaranteed due to the lack of testing infra. (support policy?) |
Thanks for testing this. |
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit deee9ac. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
…ve macOS 12 pyarrow wheels (#44315) ### Rationale for this change We did just bump MACOSX_DEPLOYMENT_TARGET from 10 to 12 for pyarrow wheels on 18.0.0, we probably should wait a little before dropping. ### What changes are included in this PR? Revert moving macOS deployment target to 12 ### Are these changes tested? Will trigger wheel jobs on archery ### Are there any user-facing changes? Yes, wheels will be available for macOS 12. * GitHub Issue: #44314 Authored-by: Raúl Cumplido <[email protected]> Signed-off-by: Sutou Kouhei <[email protected]>
Rationale for this change
We did just bump MACOSX_DEPLOYMENT_TARGET from 10 to 12 for pyarrow wheels on 18.0.0, we probably should wait a little before dropping.
What changes are included in this PR?
Revert moving macOS deployment target to 12
Are these changes tested?
Will trigger wheel jobs on archery
Are there any user-facing changes?
Yes, wheels will be available for macOS 12.