Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C#] Add support for sending dictionary arrays via flight #38045

Open
alexwilcoxson-rel opened this issue Oct 5, 2023 · 0 comments · May be fixed by #44426
Open

[C#] Add support for sending dictionary arrays via flight #38045

alexwilcoxson-rel opened this issue Oct 5, 2023 · 0 comments · May be fixed by #44426

Comments

@alexwilcoxson-rel
Copy link

Describe the enhancement requested

Dictionary arrays are not supported currently in dotnet flight implementation

Initially implement dictionary support where dictionary messages are resent with every record batch. This is not as optimal as proper dictionary reuse and delta support but will unlock ability to leverage dictionary batches over flight. Related work in Rust Arrow implementation: apache/arrow-rs#4896

Component(s)

C#

@alexwilcoxson-rel alexwilcoxson-rel changed the title Add support for sending dictionary arrays via flight [C#] Add support for sending dictionary arrays via flight Oct 5, 2023
CurtHagenlocher pushed a commit that referenced this issue Oct 15, 2024
…44377)

### Rationale for this change

See #44361. This allows testing compatibility of the .NET Flight implementation with other Flight implementations.

### What changes are included in this PR?

* Adds a new `Apache.Arrow.Flight.IntegrationTest` project that can run in server or client mode for Flight integration tests.
* Includes the integration tests that send then retrieve data defined in JSON files, but doesn't add any of the named scenarios
* Configures archery to include C# in the Flight integration tests, but skip all the named scenarios
* Also skips tests that use dictionary data due to #38045, and the empty data test due to #44363

### Are these changes tested?

These changes are tests.

### Are there any user-facing changes?

No
* GitHub Issue: #44361

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
amoeba pushed a commit that referenced this issue Nov 11, 2024
…44377)

### Rationale for this change

See #44361. This allows testing compatibility of the .NET Flight implementation with other Flight implementations.

### What changes are included in this PR?

* Adds a new `Apache.Arrow.Flight.IntegrationTest` project that can run in server or client mode for Flight integration tests.
* Includes the integration tests that send then retrieve data defined in JSON files, but doesn't add any of the named scenarios
* Configures archery to include C# in the Flight integration tests, but skip all the named scenarios
* Also skips tests that use dictionary data due to #38045, and the empty data test due to #44363

### Are these changes tested?

These changes are tests.

### Are there any user-facing changes?

No
* GitHub Issue: #44361

Authored-by: Adam Reeve <[email protected]>
Signed-off-by: Curt Hagenlocher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant