Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to deprecation messages #6782

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Nov 23, 2024

Version is inferred from first release tag containing the commit that added the deprecation.

cc @alamb

Version is inferred from first release tag containing the commit that
added the deprecation.
@github-actions github-actions bot added parquet Changes to the parquet crate arrow Changes to the arrow crate object-store Object Store Interface labels Nov 23, 2024
@alamb
Copy link
Contributor

alamb commented Nov 24, 2024

Thank you @findepi -- I was indeed thinking that this would be super helpful ❤️

And here is a beautiful PR

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you -- I didn't re-check all the versions but they all look plausible to me.

@alamb alamb merged commit f033e4f into apache:main Nov 24, 2024
33 checks passed
@findepi findepi deleted the findepi/add-version-to-deprecation-messages-ce57bf branch November 25, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate object-store Object Store Interface parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants