fix: bad cast to Decimal128 for negative precision #6413
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am depressed about the large review backlog in this crate. We are looking for more help from the community reviewing PRs -- see #6418 for more |
wjones127
reviewed
Sep 19, 2024
Comment on lines
-8124
to
+8114
| assert_eq!("1123450", decimal_arr.value_as_string(0)); | ||
| assert_eq!("2123450", decimal_arr.value_as_string(1)); | ||
| assert_eq!("3123450", decimal_arr.value_as_string(2)); | ||
| assert_eq!("11234560", decimal_arr.value_as_string(0)); | ||
| assert_eq!("21234560", decimal_arr.value_as_string(1)); | ||
| assert_eq!("31234560", decimal_arr.value_as_string(2)); |
There was a problem hiding this comment.
I'm not sure this behavior change is actually what we want 🤔
See my comment in this issue: #5793 (comment)
If we do commit this, we should mark this as breaking-change.
tustvold
added
the
next-major-release
|
@alamb @jayzhan211 I'm closing this as this is inconsistent with Postgres' behavior on fixed-point decimal casting. In fact, what actually needs to change is the documentation to reflect the proper behavior. Its parent issue is already closed. I'll make the change in the docs and open a separate PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5793.
Rationale for this change
Refer to issue.
What changes are included in this PR?
Are there any user-facing changes?
No.