Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential race on modifying __init__.py for providers #45196

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 24, 2024

Two things:

  • limit number of init.py files that might trigger the update
  • make the updates serial

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Two things:

* limit number of __init__.py files that might trigger the update
* make the updates serial
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
This should bring in some optimisation and prevent this case

@potiuk potiuk merged commit f27eb71 into apache:main Dec 24, 2024
44 of 46 checks passed
@potiuk potiuk deleted the fix-race-condition-on-modifying-init_py_files branch December 24, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants