fix GCSToGCSOperator bug when copy single object with replace to False #45181
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a small bug in GCSToGCSOperator when copy single object with replace to False.
Currently, when replace set to False, the set operation is used to check replacing file(s).
It works well except in line 412 of _copy_source_without_wildcard function that check
objects
is a single object. An error occurred while this if statement tries to get element by index from set object.if len(objects) == 1 and objects[0][-1] != "/":
I simply convert back to a list. It will not affect other downstream because other
objects
are a list too.I also attached an error log that I found this bug last month.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.