Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update min version of click also in airflow to 8.1.8 #45177

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 23, 2024

Click introduced breaking change for breeze opts behaviour fixed in #45156 however it did not force breeze image to upgrade click to newer version and it could have caused out-dated images to use older click version even if the image has been rebuilt.

This PR also updates click version in the breeze image.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Click introduced breaking change for breeze opts behaviour
fixed in apache#45156 however it did not force breeze image to upgrade
click to newer version and it could have caused out-dated
images to use older click version even if the image has been
rebuilt.

This PR also updates click version in the breeze image.
@potiuk potiuk mentioned this pull request Dec 23, 2024
@potiuk potiuk requested a review from amoghrajesh December 23, 2024 13:52
@potiuk
Copy link
Member Author

potiuk commented Dec 23, 2024

cc: @raphaelauv -> that's why your hash generated in #45149 was different.

@potiuk potiuk requested a review from eladkal December 23, 2024 13:53
@potiuk potiuk added the backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch label Dec 23, 2024
@potiuk potiuk merged commit a2b18d8 into apache:main Dec 23, 2024
123 checks passed
@potiuk potiuk deleted the also-update-min-click-version-in-airflow-doc branch December 23, 2024 14:09
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
…5177)

Click introduced breaking change for breeze opts behaviour
fixed in #45156 however it did not force breeze image to upgrade
click to newer version and it could have caused out-dated
images to use older click version even if the image has been
rebuilt.

This PR also updates click version in the breeze image.
(cherry picked from commit a2b18d8)

Co-authored-by: Jarek Potiuk <[email protected]>
Copy link

Backport successfully created: v2-10-test

Status Branch Result
v2-10-test PR Link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-to-v2-10-test Mark PR with this label to backport to v2-10-test branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants