Fix branch filter pattens for provider branches in ci workflow #45162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
hussein-awala,
jedcunningham,
gopidesupavan and
eladkal
potiuk
force-pushed
the
fix-filters-for-provider-branches
branch
from
e8a0e98 to
6a959af
Compare
potiuk
force-pushed
the
fix-filters-for-provider-branches
branch
from
6a959af to
9cbb092
Compare
gopidesupavan
approved these changes
Dec 22, 2024
|
Tested here, yes hope it works this time :) 
|
The problem is ... it's not regexp. It's not glob either. It's something GitHub speciific https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet For example they only support select ranges lile |
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Dec 22, 2024
…e#45162) I **hope** this time it will be ok: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet (cherry picked from commit 2535f4e)
potiuk
added a commit
that referenced
this pull request
Dec 22, 2024
… (#45166) I **hope** this time it will be ok: https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet (cherry picked from commit 2535f4e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this time it will be ok:
https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#filter-pattern-cheat-sheet
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.