Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add triggering PR and Push workflows for provider branches #45159

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 22, 2024

With FAB 1.5.2 we have the first case where we need to build and release providers for old version. That requires pull_request and push workflows to start when they are targetted against providers-*/v[VERSION] branches.

The .asf.yaml is updated to make providers-fab/v1-5 protected and documentation of provider's lifecycle is updated to explain how we work with releasing past versions of providers.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

cc: @shubhamraj-git

With FAB 1.5.2 we have the first case where we need to build and
release providers for old MAJOR version. That requires `pull_request`
and `push` workflows to start when they are targetted against
`providers-*/v[VERSION]` branches.

The .asf.yaml is updated to make providers-fab/v1-5 protected and
documentation of provider's lifecycle is updated to explain how
we work with releasing past versions of providers.
@potiuk potiuk force-pushed the add-pull-request-and-push-triggering-for-providers-backport branch from 5662089 to 7147e52 Compare December 22, 2024 17:49
Copy link
Contributor

@jscheffl jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh, I feared this when the breaking chnges for FAB came in... let complexity get started :-D

@potiuk
Copy link
Member Author

potiuk commented Dec 22, 2024

Oooh, I feared this when the breaking chnges for FAB came in... let complexity get started :-D

It's actually very straightforward :). And I am glad we can finally try it.

@potiuk potiuk merged commit 270eb13 into apache:main Dec 22, 2024
96 checks passed
@potiuk potiuk deleted the add-pull-request-and-push-triggering-for-providers-backport branch December 22, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants