AIP-81 Add Insert Multiple Pools API

[jason810496]

closes: #43896
related: #43657

Fix: Add max_length=256 for PoolPostBody.pool

The model defined in https://github.com/apache/airflow/blob/main/airflow/models/pool.py#L54 enforces a string length constraint on Pool.pool. To maintain consistency, this constraint should also be validated at the router level.

Refactor: Handle Duplicate Cases in Insert Pool

The Insert Pool (single insert) functionality should account for cases where a duplicate pool name is provided, as Pool.pool is defined with a unique constraint.

Feat: Add Insert Multiple Pools API

A new API endpoint for inserting multiple pools has been introduced as /pools/bulk. Alternative names such as /pools/batch or /pools/multiple were considered. Feedback on which name best describes the endpoint is welcome.

[pierrejeambrun]

Nice thanks

[bugraoz93]

Looks good! Thanks for the changes @jason810496! I believe the CI failure is likely a transient error caused by a DNS issue that couldn’t resolve AWS S3 at that moment.

[Lee-W]

Looks good! Thanks for the changes @jason810496! I believe the CI failure is likely a transient error caused by a DNS issue that couldn’t resolve AWS S3 at that moment.

just reran. seems to work fine 👀

[jason810496]

Just resolved the issue with inserting duplicate pools by handling the database exception rather than adding extra logic to the datamodels or performing additional database queries.
By the way, I’m happy to work further on refactoring to handle duplicate insertion cases across all endpoints 🙌

[pierrejeambrun]

Looking good, one minor nit, we can merge then.

[pierrejeambrun]

By the way, I’m happy to work further on refactoring to handle duplicate insertion cases across all endpoints 🙌

That would be great. You can create an issue to track that if you're not going to work on it directly just so we do not forget about it. If you plan on tackling that right away, no need to create an issue opening a PR is perfectly fine.

[pierrejeambrun]

maybe this is not the best approach

stale

[pierrejeambrun]

Really nice. I like the exception handler class approach (private classes, only expose array of handlers), and the factory pattern for registering the handlers, good idea.

A couple of nitpicks, ready to merge after that.

[jason810496]

Just fixed the nit. I will refactor all endpoints to adopt the global error handler for managing unique constraint violation errors in further PR.

[pierrejeambrun]

Just fixed the nit. I will refactor all endpoints to adopt the global error handler for managing unique constraint violation errors in further PR.

Nice. 🎉

What is great about that is the exception_handler is global to the application. All endpoints should benefit from it without any additional specifications. The only thing I can thing of is to correctly document the 409 that can be possibly returned. (That's the benefit of this approach)