Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include doc-only commit in provider commit history #43543

Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Oct 31, 2024

When we generated list of commits for provider's documentation, we only checked for commits from the source folders of the providers, however there were some commits that only changed documentation for the provider and such commits were not included.

This PR adds documentation folder to be used while checkign for the commit list, and next time when documentation will be generated for providers, the doc-only commits should also be included for all historical versions of providers.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

When we generated list of commits for provider's documentation, we
only checked for commits from the source folders of the providers,
however there were some commits that only changed documentation for
the provider and such commits were not included.

This PR adds documentation folder to be used while checkign for
the commit list, and next time when documentation will be generated
for providers, the doc-only commits should also be included for
all historical versions of providers.
@potiuk potiuk merged commit 8308dad into apache:main Oct 31, 2024
6 checks passed
@potiuk potiuk deleted the include-documentation-in-commit-list-generation branch October 31, 2024 09:16
Copy link
Contributor

@amoghrajesh amoghrajesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw this now! Nice

ellisms pushed a commit to ellisms/airflow that referenced this pull request Nov 13, 2024
When we generated list of commits for provider's documentation, we
only checked for commits from the source folders of the providers,
however there were some commits that only changed documentation for
the provider and such commits were not included.

This PR adds documentation folder to be used while checkign for
the commit list, and next time when documentation will be generated
for providers, the doc-only commits should also be included for
all historical versions of providers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants