-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for chicken-egg providers to dockerhub release process #36002
Add support for chicken-egg providers to dockerhub release process #36002
Conversation
Testing the workflow changes here: https://github.com/apache/airflow/actions/runs/7059328822 |
470e085
to
284f6df
Compare
284f6df
to
2f5fb2a
Compare
2f5fb2a
to
cd0ecbc
Compare
Third attempt (getting closer) : https://github.com/apache/airflow/actions/runs/7059678993 |
cd0ecbc
to
862d0b1
Compare
862d0b1
to
a82cbe0
Compare
One step closer: https://github.com/apache/airflow/actions/runs/7060262963 - we need to also support case where airflow + other providers is installed from PyPI but the single provider from local docker-context-files (also added a documentation describing why we are doing it and how) |
a82cbe0
to
2b73d87
Compare
2b73d87
to
7ca71bd
Compare
OK. The workflow passed here (including image verification step) - (with some intermittent failure for 3.11 which I re-run) https://github.com/apache/airflow/actions/runs/7060444121 And the 2.8.0b1 images now contain the common.io provider:
|
(note - you will need to pull the images again if you pulled them previously ) |
I will work on getting a new beta. WDYT? |
I think it makes sense only if this one is merged an there are other fixes cherry-picked - but yeah - why not :) BTW. There is also a very small caveat / edge case. Those images that use chicken-egg providers, do not use "constraints" mainly because - like this is in this case - they use pre-release version of the "chicken-egg providers" build from sources. So they are generally getting latest matching versions of packages from PyPI, not the ones in the constraints. This is likely never going to cause us problems - because in 9X% of cases they will be the same as constraints, but there is a very small probability that someone released new versions of package between the moment where constraints were updated (when Package is released) and when the image has been built (which will usually happen 10-20 minutes later) So it's not |
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.