Remove None from param definition, adjust the log of wrong DagRun typ…

…e in parameters and test
apache · Dec 23, 2024 · f957ac4 · f957ac4
1 parent f3908ee
commit f957ac4
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 20 deletions.
diff --git a/airflow/api_fastapi/common/parameters.py b/airflow/api_fastapi/common/parameters.py
@@ -538,7 +538,7 @@ def _transform_dag_run_types(types: list[str] | None) -> list[DagRunType | None]
     except ValueError:
         raise HTTPException(
             status_code=status.HTTP_422_UNPROCESSABLE_ENTITY,
-            detail=f"Invalid value for state. Valid values are {', '.join(DagRunType)}",
+            detail=f"Invalid value for run type. Valid values are {', '.join(DagRunType)}",
         )
 
 
@@ -635,8 +635,8 @@ def _optional_boolean(value: bool | None) -> bool | None:
     return value if value is not None else False
 
 
-QueryIncludeUpstream = Annotated[Union[bool, None], AfterValidator(_optional_boolean)]
-QueryIncludeDownstream = Annotated[Union[bool, None], AfterValidator(_optional_boolean)]
+QueryIncludeUpstream = Annotated[Union[bool], AfterValidator(_optional_boolean)]
+QueryIncludeDownstream = Annotated[Union[bool], AfterValidator(_optional_boolean)]
 
 state_priority: list[None | TaskInstanceState] = [
     TaskInstanceState.FAILED,

diff --git a/airflow/api_fastapi/core_api/openapi/v1-generated.yaml b/airflow/api_fastapi/core_api/openapi/v1-generated.yaml
@@ -222,18 +222,14 @@ paths:
         in: query
         required: false
         schema:
-          anyOf:
-          - type: boolean
-          - type: 'null'
+          type: boolean
           default: false
           title: Include Upstream
       - name: include_downstream
         in: query
         required: false
         schema:
-          anyOf:
-          - type: boolean
-          - type: 'null'
+          type: boolean
           default: false
           title: Include Downstream
       - name: root
@@ -353,18 +349,14 @@ paths:
         in: query
         required: false
         schema:
-          anyOf:
-          - type: boolean
-          - type: 'null'
+          type: boolean
           default: false
           title: Include Upstream
       - name: include_downstream
         in: query
         required: false
         schema:
-          anyOf:
-          - type: boolean
-          - type: 'null'
+          type: boolean
           default: false
           title: Include Downstream
       - name: logical_date_gte

diff --git a/airflow/ui/openapi-gen/requests/types.gen.ts b/airflow/ui/openapi-gen/requests/types.gen.ts
@@ -1509,8 +1509,8 @@ export type HistoricalMetricsResponse = HistoricalMetricDataResponse;
 export type StructureDataData = {
   dagId: string;
   externalDependencies?: boolean;
-  includeDownstream?: boolean | null;
-  includeUpstream?: boolean | null;
+  includeDownstream?: boolean;
+  includeUpstream?: boolean;
   root?: string | null;
 };
 
@@ -1567,8 +1567,8 @@ export type CancelBackfillResponse = BackfillResponse;
 
 export type GridDataData = {
   dagId: string;
-  includeDownstream?: boolean | null;
-  includeUpstream?: boolean | null;
+  includeDownstream?: boolean;
+  includeUpstream?: boolean;
   limit?: number;
   logicalDateGte?: string | null;
   logicalDateLte?: string | null;

diff --git a/tests/api_fastapi/core_api/routes/ui/test_grid.py b/tests/api_fastapi/core_api/routes/ui/test_grid.py
@@ -2799,7 +2799,7 @@ def test_should_response_200_run_types(self, test_client, run_type, expected):
         [
             (
                 ["invalid"],
-                {"detail": f"Invalid value for state. Valid values are {', '.join(DagRunType)}"},
+                {"detail": f"Invalid value for run type. Valid values are {', '.join(DagRunType)}"},
             )
         ],
     )
-Original file line number
+Diff line change
@@ Expand Up @@
             [
                 (
                     ["invalid"],
-                    {"detail": f"Invalid value for state. Valid values are {', '.join(DagRunType)}"},
+                    {"detail": f"Invalid value for run type. Valid values are {', '.join(DagRunType)}"},
                 )
             ],
         )
@@ Expand Down @@