WIP: [AMQ-9637] Add web socket connection limit. #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattrpav
changed the title
|
On the surface, this looks like it might be a couple of commits-- ws socket handling clean-up and then the limit added. TODO: Determine if this is done before or after the Jetty 12 update |
sounds good. I will split the PR into two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problems does this PR solve?
It adds
maximumConnectionssupport for WS transport.Why is it beneficial to merge into ActiveMQ?
all other transports have this limit. being able to limit the number of connections for WS transport brings in in par with the rest of transports.
How do you make sure this PR is well tested?
I updated the existing amqp test to test amqp+ws and amqp+wss, added new tests for stomp+ws and mqtt+ws as well.