Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Jolokia 2.1.1. Remove json-simple 1.1.1 #1356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Upgrade to Jolokia 2.1.1. Remove json-simple 1.1.1 #1356

wants to merge 1 commit into from

Conversation

PaulGale
Copy link

Fixes AMQ-9626

@jbonofre jbonofre self-requested a review November 20, 2024 21:03
@mattrpav
Copy link
Contributor

Is json-simple no longer needed?

@mattrpav mattrpav self-requested a review November 20, 2024 21:06
@PaulGale
Copy link
Author

Jolokia no longer depends on json-simple.

json-simple is no longer maintained. It was last updated in 2012.

Jolokia 2.1.1 now includes builtin JSON functionality which ships in jolokia-json.jar. The assembly packaging has been updated accordingly.

See here for the details of the Jolokia change: jolokia/jolokia#686

@jbonofre
Copy link
Member

@mattrpav jolokia 2.1 now uses it's own json lib (json-simple is useless now with Jolokia 2.1).

mattrpav
mattrpav approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@mattrpav mattrpav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattrpav mattrpav mattrpav approved these changes

@jbonofre jbonofre jbonofre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PaulGale @mattrpav @jbonofre