Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: CP support collapse expandIcon #47473

Merged
merged 10 commits into from
Feb 20, 2024
Merged

feat: CP support collapse expandIcon #47473

merged 10 commits into from
Feb 20, 2024

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Feb 19, 2024 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: CP support collapse expandIcon
🇨🇳 Chinese feat: CP support collapse expandIcon

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

👁 Visual Regression Report for PR #47473 Passed ✅

🎯 Target branch: feature (b96f4c8)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

Preview is ready

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
./dist/antd.min.js 333.8 KB (+1 B 🔺)
./dist/antd-with-locales.min.js 379.59 KB (+85 B 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Feb 19, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov Codecov
Copy link

codecov bot commented Feb 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b96f4c8) 100.00% compared to head (345a414) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##           feature    #47473   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          734       734           
  Lines        12615     12617    +2     
  Branches      3306      3307    +1     
=========================================
+ Hits         12615     12617    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc
Copy link
Member

MadCcc commented Feb 19, 2024

这个 icon 应该不需要放到 CP 上，不是一个通用配置

@li-jia-nan li-jia-nan changed the title feat: CP support Avatar icon feat: CP support collapse expandIcon Feb 19, 2024
@li-jia-nan
Copy link
Member Author

这个 icon 应该不需要放到 CP 上，不是一个通用配置

改成 collapse 了

@li-jia-nan li-jia-nan requested a review from MadCcc February 20, 2024 03:16
@li-jia-nan li-jia-nan requested a review from MadCcc February 20, 2024 04:08
@MadCcc MadCcc merged commit cf51b5f into feature Feb 20, 2024
105 checks passed
@MadCcc MadCcc deleted the avatar branch February 20, 2024 06:02
@github-actions GitHub Actions
Copy link
Contributor

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。

@xrkffgg xrkffgg mentioned this pull request Mar 1, 2024
Merged
tanzhenyun pushed a commit to DraculaPrince/mark15 that referenced this pull request Mar 29, 2024
@li-jia-nan
feat: CP support collapse expandIcon (ant-design#47473)
45d1322 
* feat: CP support Avatar icon

* fix: fix

* fix: fix

* test: fix test case

* fix: fix

* fix: fix type

* Update avatar.tsx

Signed-off-by: lijianan <[email protected]>

* Update avatar.tsx

Signed-off-by: lijianan <[email protected]>

---------

Signed-off-by: lijianan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadCcc MadCcc MadCcc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@li-jia-nan @MadCcc