-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: config support holderRender #46596
Conversation
Run & review this pull request in StackBlitz Codeflow. |
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5e44757:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #46596 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 718 718
Lines 12214 12241 +27
Branches 3229 3236 +7
=========================================
+ Hits 12214 12241 +27 ☔ View full report in Codecov by Sentry. |
测试没过 |
语义有点过于模糊。。。 我感觉业务里自己封装静态方法反而自由度会更高一些? |
api 名可以再讨论 目前 config 有 prefixCls theme 等,也为此做了许多维护,增加一个 wrapper 可以让用户自己配置,antd 就可以不用再维护了 |
也有道理 |
2 个 todo
|
[中文版模板 / Chinese template]
🤔 This is a ...
RFC #46615
静态组件
message
Modal
notification
无法设置hashPriority="high"
给:where
降级等,增加holderRender
方法,让用户自定义包裹🔗 Related issue link
💡 Background and solution
📝 Changelog
ConfigProvider.config
supportholderRender
ConfigProvider.config
支持holderRender
☑️ Self-Check before Merge