Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Delete the rate useless css #45927

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Conversation

JarvisArt
Copy link
Contributor

@JarvisArt JarvisArt commented Nov 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • [] Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English 删除Rate组件无用css
🇨🇳 Chinese Delete the rate useless css

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖[deprecated] Generated by Copilot at c5d3244

Refactored the Rate component demos and styles to use the Space component for layout, and removed unnecessary custom styles. This improves the consistency and simplicity of the Rate component usage and appearance.

🔍 Walkthrough

🤖[deprecated] Generated by Copilot at c5d3244

  • Refactor the layout of the Rate component and its text to use the Space component instead of custom styles (link, link, link, link)

Copy link

stackblitz bot commented Nov 16, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Nov 16, 2023

Preview Is ready

Copy link

codesandbox-ci bot commented Nov 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dee875c:

Sandbox Source
antd reproduction template (forked) Configuration

Copy link

argos-ci bot commented Nov 16, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 2 changes Nov 20, 2023, 2:07 AM

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (48e9bca) 100.00% compared to head (dee875c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #45927   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          700       700           
  Lines        11847     11847           
  Branches      3157      3157           
=========================================
  Hits         11847     11847           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163
Copy link
Member

afc163 commented Nov 20, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 321.51 KB (-141 B 🔽)
./dist/antd-with-locales.min.js 367.12 KB (-75 B 🔽)

@afc163 afc163 merged commit d8d53f1 into ant-design:master Nov 20, 2023
55 checks passed
@zombieJ zombieJ mentioned this pull request Nov 22, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants