Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: enable type prompt for .dumirc.ts #44886

Merged
merged 8 commits into from
Sep 17, 2023
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Sep 15, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Please append `.dumi/**/*` & `.dumirc.ts` into `include` option of `tsconfig.json`, to make sure the types exported by framework works.

📝 Changelog

Language Changelog
🇺🇸 English --
🇨🇳 Chinese --

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at d65ab80

Enabled TypeScript support for the documentation site by modifying the tsconfig.json file for dumi. Added the .dumirc.ts file to the include property and extended the base tsconfig.json file.

🔍 Walkthrough

🤖 Generated by Copilot at d65ab80

  • Enable TypeScript support for the documentation site by:
    • Including the .dumirc.ts file in the include property of .dumi/tsconfig.json (link)
    • Extending the base tsconfig.json file from the root directory in the extends property of .dumi/tsconfig.json (link)

@stackblitz
Copy link

stackblitz bot commented Sep 15, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 15, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 393.98 KB
./dist/antd-with-locales.min.js 453.17 KB

@argos-ci
Copy link

argos-ci bot commented Sep 15, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Sep 17, 2023, 1:27 PM

@afc163
Copy link
Member Author

afc163 commented Sep 15, 2023

.dumi 里这么多报错。。。

@li-jia-nan
Copy link
Member

.dumi 里这么多报错。。。

我来修

@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5ac472d) 100.00% compared to head (35ce5b9) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44886   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          682       682           
  Lines        11540     11540           
  Branches      3105      3105           
=========================================
  Hits         11540     11540           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan
Copy link
Member

本地居然不报错,奇怪

@MadCcc
Copy link
Member

MadCcc commented Sep 15, 2023

.dumi 文件夹有自己的 tsconfig,应该 extends 一下

.dumi/tsconfig.json Outdated Show resolved Hide resolved
Signed-off-by: lijianan <[email protected]>
@PeachScript
Copy link
Member

dumi 层的 warning 有问题,.dumi/** 不应该包含进来,这个 PR 我来跟进吧,先把 dumi 层的 warning 修了再看 PR 里怎么调整

@PeachScript PeachScript marked this pull request as draft September 15, 2023 08:32
@PeachScript PeachScript marked this pull request as ready for review September 17, 2023 13:01
@PeachScript PeachScript changed the title type: fix .dumi missing types type: enable type prompt for .dumirc.ts Sep 17, 2023
@PeachScript
Copy link
Member

已更新,大家再 review 看看

@li-jia-nan li-jia-nan merged commit 62e338c into master Sep 17, 2023
89 checks passed
@li-jia-nan li-jia-nan deleted the type/fix-dumi-types branch September 17, 2023 13:52
@li-jia-nan li-jia-nan mentioned this pull request Sep 17, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants