Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site: solve display exception when use happy work theme in dark mode #44720

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Sep 8, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English solve display exception when use happy work theme in dark mode
🇨🇳 Chinese 解决暗黑模式下使用快乐工作主题时首页展示异常问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 70c696e

Support dark mode for antd theme in dumi docs. Modify getAlgorithm function in .dumi/theme/layouts/GlobalLayout.tsx to use dark algorithm if themes include 'dark'.

🔍 Walkthrough

🤖 Generated by Copilot at 70c696e

  • Add dark mode support for the antd theme in the dumi documentation tool (link, F

@stackblitz
Copy link

stackblitz bot commented Sep 8, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

@kiner-tang kiner-tang requested review from afc163 and zombieJ September 8, 2023 14:37
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 393.42 KB
./dist/antd-with-locales.min.js 452.62 KB

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (32d0a1f) 100.00% compared to head (2f56f35) 100.00%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44720   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          680       681    +1     
  Lines        11417     11438   +21     
  Branches      3073      3080    +7     
=========================================
+ Hits         11417     11438   +21     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit b9dfb18 into master Sep 11, 2023
86 checks passed
@MadCcc MadCcc deleted the site-happly-work branch September 11, 2023 03:17
}
return null;
})
.filter((item) => item);
Copy link
Member

@li-jia-nan li-jia-nan Sep 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.filter(Boolean);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants