-
-
Notifications
You must be signed in to change notification settings - Fork 50.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: transfer label height #44471
fix: transfer label height #44471
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Vue 的? 这里是 React 的哦 |
一样的有这个问题 |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44471 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 661 662 +1
Lines 11231 11243 +12
Branches 3042 3043 +1
=========================================
+ Hits 11231 11243 +12
☔ View full report in Codecov by Sentry. |
我的电脑没复现问题, 可以先提供一个复现链接吗? |
我的描述里面加了一个 gif 你可以看一下 |
@yoyo837 |
无法复现呢 |
@yoyo837 啊这,那你看我截的图呢。问题其实就是 点击 label 那块既触发了 item 的 selectChange,然后 label 点击后又修改了 checkbox 的值又触发一次 selectChange |
但你提供的复现并不能复现, 所以暂时只能认为是正常的. |
你自己打开这个复现是能复现问题的吗? |
@yoyo837 我把 label 放大了一点,你再看看复现链接 |
你可以看我最上面那条 贴的 gif |
看到了 |
@yoyo837 所以为什么你那里没复现成功 😂 |
没get到复现手法, 已经能复现了 |
Please rebase upstream. |
changelog应该提及会触发两次事件问题的修复. |
🤔 This is a ...
🔗 Related issue link
vueComponent/ant-design-vue#6010
antd 同样存在这个问题
💡 Background and solution
fix: #44489
正常应该只是触发一次,但是触发了两次
修复:
->
📝 Changelog
label
tag with the height of the childspan
tag. Otherwise, when clicking on the area inside the label and outside the checkbox, theonSelectChange
event will be triggered twiceonSelectChange
事件☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 30b9576
Fix checkbox label alignment and improve transfer component usability. Add a CSS rule to
&-checkbox
incomponents/transfer/style/index.ts
and make other changes related to accessibility, keyboard navigation, and style consistency.🔍 Walkthrough
🤖 Generated by Copilot at 30b9576
[link](https://github.com/ant-design/ant-design/pull/44471/files?diff=unified&w=0#diff-d9d90f3711c4b10ecac467dc5d915fd5e15d8398916ed340a5ca70968394f2cbR308-R311)
)