Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/getting-started.rst: Add missing argument to init role #2986

Merged
merged 1 commit into from
Nov 20, 2020

Conversation

apatard
Copy link
Contributor

@apatard apatard commented Nov 20, 2020

The default driver is 'delegated' nowadays and this document is
about using the 'docker' driver, so "--driver-name docker" has to
be appended to the "molecule init role" command line.

Ref: #2916
Signed-off-by: Arnaud Patard [email protected]

PR Type

  • Docs Pull Request

The default driver is 'delegated' nowadays and this document is
about using the 'docker' driver, so "--driver-name docker" has to
be appended to the "molecule init role" command line.

Ref: ansible#2916
Signed-off-by: Arnaud Patard <[email protected]>
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am inclined to remove the docker references from the guide instead? This would make the guide much easier to follow. Once the user is able to run with default delegated he could look for another guide on how to do it with another driver?

@apatard
Copy link
Contributor Author

apatard commented Nov 20, 2020

I thought about doing that too but I took the quickest way to fix the issue and made this PR.
I agree that moving this doc to a different part and provide a new "Getting Started" with the (default) delegated driver is the way to go but it will take a little bit more time. In the mean time, the current doc will still be broken.

@ssbarnea ssbarnea added the docs label Nov 20, 2020
@ssbarnea ssbarnea merged commit 89a96b0 into ansible:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants