surface write errors through flush
#138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: David House <[email protected]> Co-Authored-By: Doug Patti <[email protected]>
anmonteiro
force-pushed
the
anmonteiro/surface-write-errors-on-flush
branch
from
947293b to
f3f07f1
Compare
|
this change doesn't yet do the same for the |
anmonteiro
added a commit
to anmonteiro/opam-repository
that referenced
this pull request
Sep 4, 2024
CHANGES: - client: report exceptions before closing the response body ([anmonteiro/httpun#135](anmonteiro/httpun#135)) - server: process requests after EOF ([anmonteiro/httpun#136](anmonteiro/httpun#136)) - surface (body) write errors through `flush` ([anmonteiro/httpun#138](anmonteiro/httpun#138)) - `Body.Writer.flush` now takes a callback of the type ``([ `Written | ` Closed] -> unit)``, informing the caller whether the previous writes have been written or whether the output channel was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports inhabitedtype/httpaf#217 to httpun