feat: Wallet part of the https deeplinking #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Lanser <[email protected]>
Signed-off-by: Tom Lanser <[email protected]>
Signed-off-by: Tom Lanser <[email protected]>
Signed-off-by: Tom Lanser <[email protected]>
Signed-off-by: Tom Lanser <[email protected]>
janrtvld
reviewed
Nov 30, 2023
Co-authored-by: Jan <[email protected]>
janrtvld
approved these changes
Nov 30, 2023
Signed-off-by: Tom Lanser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't tested yet on Android for some reason I can't get it to start.
I also added the workaround for the
didcomm://https://agent.example.com/didcomm?oob=xxxxxso that is also possible now.The workaround is something what I found by accident. I tried more things but all of them were not possible. Some were not possible because the routing was earlier than the deeplink detection.
Also didn't find anything about it in React router, solite and tamagui.