feat: add jwt-vc support #8
Conversation
Signed-off-by: Timo Glastra <[email protected]>
Signed-off-by: Timo Glastra <[email protected]>
|
Now fully works with JWT credentials (have removed support for JSON-LD as it doesn't work without patches). The credential rendering now infers a name for the credential from the type if the credential doesn't include it and satizies that, but the issuer is not really inferable. @janrxyz this is how it looks now. Maybe you can take a look and make sure it account properly for the case where we don't have any metadata at all (in same cases we maybe don't even have a name) You can check several credentials on https://jff.walt.id/
|
|
|
Signed-off-by: Timo Glastra <[email protected]>
| key={credentialRecord.id} | ||
| // FIXME: what do we do if there's no name of the credential or the issuer? | ||
| // We can extract the name from the credential type maybe, but that's quite hacky. | ||
| name={display.name ?? ''} |
There was a problem hiding this comment.
Should we check the values here? Or should we always return a name in getCredentialForDisplay?
There was a problem hiding this comment.
I think we should set a default in the getCredentialForDisplay, so we always have a unified representation of a credential. What do you think?
What should the default name be in that case though?
There was a problem hiding this comment.
Agreed, makes components look cleaner. We can try and extract it from the type? Or name it Credential from <ISSUER_NAME> if that is less hacky. I think everything is better than nothing.
There was a problem hiding this comment.
I already try to extract it from the type, but only when there's more than one and it isn't an url.
Otherwise it will be VerifiableCredential, which is a bit useless.
In some cases we also don't have an issuer, so we really don't have any variable sometiems. Should it just be 'Credential' in that case?
Fun idea: I think AI would be quite good to come up with a name based on the fields (if there's a simple on-device tool for it)
There was a problem hiding this comment.
I guess 'Credential' should suffice for now.
Great AI use case. We can use AI to select a fitting icon for the credential as well, or even a fitting background image.
|
I'll take a look after this is merged. |
Signed-off-by: Timo Glastra <[email protected]>
Adds support for latest AFJ with JWT VC support. As the JWT creds don't have the credential display, I changed the display logic a bit and separated it into a
getCredentialForDisplay. Now we don't have to change the logic in the wallet, if we want to get the properties from somewhere else.Draft as I haven't tested it yet.