Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add inbox #58

Merged
merged 2 commits into from
Aug 29, 2023
Merged

feat: add inbox #58

merged 2 commits into from
Aug 29, 2023

Conversation

TimoGlastra
Copy link
Member

Untitled.mov

Signed-off-by: Timo Glastra <[email protected]>
Copy link
Member

@Tommylans Tommylans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good maybe a small styling improvement but I'm not sure of how it would look. It can also look a bit odd maybe good to ask @janrxyz later for a quick look 😄.

<YStack jc="center" ai="center" gap="$2">
<Heading variant="h2">You're all caught up.</Heading>
<Paragraph textAlign="center" secondary>
You don't have any notifications at the moment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this a bit smaller than the title?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept it the same as the home screen when you don't have any crednetials yet. Shouild i also change that you think for consistency?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged for now, but let me know, and I'll make a follow up PR

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra merged commit 4420240 into main Aug 29, 2023
@TimoGlastra TimoGlastra deleted the feat/inbox branch August 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants