Feature/openid federation #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Lanser <[email protected]>
Signed-off-by: Tom Lanser <[email protected]>
Tommylans
force-pushed
the
feature/openid-federation
branch
from
090a081 to
2d13142
Compare
TimoGlastra
reviewed
Dec 5, 2024
| @@ -22,7 +22,10 @@ export const vCredentialRequestJwtProofTypeHeader = v.pipe( | |||
| ({ kid, jwk }) => jwk === undefined || kid === undefined, | |||
| `Both 'jwk' and 'kid' are defined. Only one is allowed` | |||
| ), | |||
| v.check(({ trust_chain, kid }) => !trust_chain || !kid, `When 'trust_chain' is provided, 'kid' is required`) | |||
| v.check( | |||
| ({ trust_chain, kid }) => !trust_chain || kid !== undefined, | |||
There was a problem hiding this comment.
Curious did you run into an issue?
There was a problem hiding this comment.
Yeah I did some work on it for supporting this property. I didn't push it with it but I had a array and a kid defined. But I still got this error so I found out that the validation is was not correct.
| * Custom fetch implementation to use | ||
| */ | ||
| fetch?: Fetch | ||
| callbackContext: Pick<CallbackContext, 'fetch' | 'verifyJwt' | 'signJwt'> |
There was a problem hiding this comment.
In the rest of the codebase i thinks it's just called callbacks
| const result = await fetchWellKnownMetadata(wellKnownMetadataUrl, vCredentialIssuerMetadataWithDraftVersion, fetch) | ||
| let result: v.InferOutput<typeof vCredentialIssuerMetadataWithDraftVersion> | null = null | ||
|
|
||
| const entityConfiguration = await fetchEntityConfiguration({ |
There was a problem hiding this comment.
I've been thinking for a while whether the approach is nice and simple, or that it misses a few things.
What i'm not sure about:
- we lose knowledge about whether federation is used
- we lose knowledge on the verification result
- metadata is dependent on the trust chain. We currently don't support metadata policies but since we will in the future i think it might be better to handle this in credo.
| if (entityConfiguration) { | ||
| const credentialIssuerMetadata = await v.safeParseAsync( | ||
| vCredentialIssuerMetadataWithDraftVersion, | ||
| entityConfiguration.metadata?.openid_provider |
There was a problem hiding this comment.
Is the issuer metadata called openid_provider?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.