Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configured eslint to work on ts files #474

Merged
merged 1 commit into from
Jul 31, 2022

Conversation

TClark1011
Copy link
Contributor

@TClark1011 TClark1011 commented Jul 19, 2022

ESLint now uses the @typescript-eslint parser to parse .ts files. .js files still use the default parser. This was done by using the overrides key in the eslint config to set the parser specifically for .ts files.

NOTE: I did not lint any files as part of this PR. My recommendation would be that if the eslint setup in this PR is approved, then a second commit should be made where all the ts files in the codebase are linted, and possibly also have prettier run on them.

Closes #472

@angus-c
Copy link
Owner

angus-c commented Jul 31, 2022

Thanks!

@angus-c angus-c merged commit 48a1ad4 into angus-c:master Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESLint is not configured to work with Typescript
2 participants