Skip to content

Commit

Permalink
Update support levels. Support > ES5 in limited cases (#462)
Browse files Browse the repository at this point in the history
  • Loading branch information
angus-c authored Jun 4, 2022
1 parent 5ee7ea7 commit bc3e3b0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Guidelines
* Modules must not depend on any other npm modules (including other just modules)
* Always assume Just modules will be used in hot code and code accordingly
* Write in ES5
* Write in ES5 when possible. If you have to support newer argument types (e.g. Set and Map) you may upgrade to newer syntax (within our stated [platform support levels](https://github.com/angus-c/just#browser-support-computer)) but please bump the major version to protect legacy users.
* Favor `for` loops over high order functions
* Don't repeatedly access the same property, assign it to a `var`
* Brevity
Expand Down
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,15 @@ We're in the process of adding TypeScript definitions and tests to every Just ut

You can verify new TypeScript definitions by running `yarn test-types` (This also gets run as part of the `yarn test` script)

## Browser Support :computer:
**UPDATE:** just-methodize is now the only module without TS definitions!

Data based on [available saucelabs test browsers](https://github.com/angus-c/just/tree/sauce). It's likely _Just_ is also fully supported by some older versions not verifiable via saucelabs.
## Browser/Platform Support :computer:

| Chrome | Safari | Firefox | Edge | Node | Mobile Safari | Android |
Most utilities will work in older versions, but these are the earliest guaranteed versions across all utilities. For guidance any platform that supports [spread in array literals](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#spread_in_array_literals) will work with Just.

| Chrome | Safari | Firefox | Edge | Node | Mobile Safari | Android Chrome |
| ------ | ------ | ------- | ---- | ---- | ------------- | ------------- |
| yes | yes | yes | 12 | 6+ | iOS 8+ | Android OS 5+ |
| 46 | 8 | 16 | 12 | 6.0 | 8 | 46 |

## The Modules :package:

Expand Down

0 comments on commit bc3e3b0

Please sign in to comment.