improve typing of array-omit

angus-c · Sep 9, 2022 · 5f98fa1 · 5f98fa1
1 parent af091d7
commit 5f98fa1
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 12 deletions.
diff --git a/packages/object-omit/index.d.ts b/packages/object-omit/index.d.ts
@@ -1,3 +1,12 @@
-declare function omit<Obj extends object, Key extends string>(obj: Obj, remove: Key[]): Omit<Obj, Key>;
-declare function omit<Obj extends object, Key extends string>(obj: Obj, remove1: Key, ...removeN: Key[]): Omit<Obj, Key>;
+declare function omit<Obj extends object, Key extends keyof Obj>(
+  obj: Obj,
+  remove: Key[]
+): Omit<Obj, Key>;
+
+declare function omit<Obj extends object, Key extends keyof Obj>(
+  obj: Obj,
+  remove1: Key,
+  ...removeN: Key[]
+): Omit<Obj, Key>;
+
 export default omit
diff --git a/packages/object-omit/index.tests.ts b/packages/object-omit/index.tests.ts
@@ -1,22 +1,19 @@
 import omit from './index';
 
 const obj = {
-	a: 1,
-	b: 2,
-	c: 3
+  a: 1,
+  b: 2,
+  c: 3
 }
 
 {
-	const test: { c: number } = omit(obj, ['a', 'b'])
+  const test: { c: number } = omit(obj, ['a', 'b'])
 }
 {
-	const test: { a: number } = omit(obj, ['b', 'c', 'd'])
+  const test: { a: number, c: number } = omit(obj, ['b', 'b', 'b'])
 }
 {
-	const test: { a: number, c: number } = omit(obj, ['b', 'b', 'b'])
-}
-{
-	const test: { b: number } = omit(obj, 'a', 'c')
+  const test: { b: number } = omit(obj, 'a', 'c')
 }
 
 // Not OK
@@ -47,4 +44,4 @@ omit({}, {}, 'a');
 // @ts-expect-error
 omit({ a: 1 }, { a: 1 });
 // @ts-expect-error
-omit([1, 2, 3], 0);
+omit({ a: 1 }, ['a', 'b']);