feat: integrate code refactorings from language-service via LSP #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Blocked on angular/angular#56895 |
atscott
approved these changes
Jul 10, 2024
devversion
added a commit
to devversion/angular
that referenced
this pull request
Jul 16, 2024
This is a performance optimization that would exit early when code actions are requested, but we know Angular cannot provide fixes based on the error codes. Previously, we would unnecessarily compute and analyze the application for semantic diagnostics. This will be helpful for: angular/vscode-ng-language-service#2050
atscott
pushed a commit
to angular/angular
that referenced
this pull request
Jul 16, 2024
This is a performance optimization that would exit early when code actions are requested, but we know Angular cannot provide fixes based on the error codes. Previously, we would unnecessarily compute and analyze the application for semantic diagnostics. This will be helpful for: angular/vscode-ng-language-service#2050 PR Close #57000
|
@atscott Take a look at this PR. A public API called getSupportedCodeFixes is used to check if the compiler can fix the diagnostics. Remove the unnecessary export custom API. |
devversion
force-pushed
the
lsp-refactorings
branch
2 times, most recently
from
d3e4d05 to
1479833
Compare
|
Note: This PR also bumps to a next release of the language service. Not sure if this is fine for the versioning in this repository— but I assume yes, given that there is a 18.x branch |
This integrates Angular's code refactorings into the extension, so that those are communicated via the LSP to VSCode.
devversion
force-pushed
the
lsp-refactorings
branch
from
1479833 to
04eb510
Compare
atscott
approved these changes
Jul 31, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates Angular's code refactorings into the extension, so that those are communicated via the LSP to VSCode.