fix: Disable block syntax parsing when no project in workspace suppor… #1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylhunn
approved these changes
Nov 8, 2023
atscott
force-pushed
the
disableBlockSyntax
branch
2 times, most recently
from
48041f8 to
83aefab
Compare
…ts it This commit adds a check to ensure a root in the workspace supports block syntax. If not, the block syntax parsing in the compiler is disabled. Note that the language server is shared for all roots and all projects in the workspace. If on supports block syntax, we have to enable it. In the future, it would be better to find a way to make this a per-project configuration based on the version of Angular used in that project. fixes angular#1958
atscott
force-pushed
the
disableBlockSyntax
branch
from
83aefab to
7d7f5d4
Compare
atscott
added
target: patch
atscott
added a commit
to atscott/vscode-ng-language-service
that referenced
this pull request
Nov 8, 2023
…ts it (angular#1962) This commit adds a check to ensure a root in the workspace supports block syntax. If not, the block syntax parsing in the compiler is disabled. Note that the language server is shared for all roots and all projects in the workspace. If on supports block syntax, we have to enable it. In the future, it would be better to find a way to make this a per-project configuration based on the version of Angular used in that project. fixes angular#1958
atscott
added a commit
that referenced
this pull request
Nov 8, 2023
…ts it (#1962) (#1964) This commit adds a check to ensure a root in the workspace supports block syntax. If not, the block syntax parsing in the compiler is disabled. Note that the language server is shared for all roots and all projects in the workspace. If on supports block syntax, we have to enable it. In the future, it would be better to find a way to make this a per-project configuration based on the version of Angular used in that project. fixes #1958
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ts it
This commit adds a check to ensure any project in the workspace supports block syntax. If not, the block syntax parsing in the compiler should be disabled. Note that the language server is shared for all projects in the workspace. If on supports block syntax, we have to enable it.
fixes #1958