Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add missing vscode-nls to npm_translate_lock hoisted package #1825

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

gregmagolan
Copy link
Contributor

@gregmagolan gregmagolan commented Nov 30, 2022

Looks like this regressed at some point. The //:npm target fails to build with

ERROR: /Users/greg/aspect/google/vscode-ng-language-service/BUILD.bazel:34:12: Copying files to directory failed: missing input file '//:node_modules/vscode-nls'
ERROR: /Users/greg/aspect/google/vscode-ng-language-service/BUILD.bazel:34:12: Copying files to directory failed: 1 input file(s) do not exist

at HEAD without this fix

@atscott atscott added target: patch This PR is targeted for the next patch release action: merge Ready to merge labels Nov 30, 2022
@atscott atscott merged commit 199a88a into angular:main Nov 30, 2022
atscott pushed a commit that referenced this pull request Nov 30, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants