Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension): Update virtualWorkspace support to allow syntax high… #1694

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

atscott
Copy link
Collaborator

@atscott atscott commented Jun 9, 2022

…lighting

You can find more information about virtual workspaces here: https://code.visualstudio.com/api/extension-guides/virtual-workspaces

The LSP does not support access to virtual resources: microsoft/language-server-protocol#1264
As a result, we cannot provide much in the way of features since the
extension relies on the LSP for every provider.

While we cannot provide any features from the @angular/language-server,
we still can provide "limited" support to enable syntax highlighting in
virtual workspaces.

…lighting

You can find more information about virtual workspaces here: https://code.visualstudio.com/api/extension-guides/virtual-workspaces

The LSP does not support access to virtual resources: microsoft/language-server-protocol#1264
As a result, we cannot provide much in the way of features since the
extension relies on the LSP for every provider.

While we cannot provide any features from the @angular/language-server,
we still can provide "limited" support to enable syntax highlighting in
virtual workspaces.
@atscott atscott added the target: minor This PR is targeted for the next minor release label Jun 9, 2022
@atscott atscott requested a review from alxhub June 9, 2022 20:05
@atscott atscott added the action: merge Ready to merge label Jun 13, 2022
@atscott atscott merged commit f8b0db8 into angular:main Jun 13, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge Ready to merge target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants