Max call stack size exceeded in StaticSymbolResolver.resolveModule #593
Comments
|
Can you provide us with the log file? It’s the fourth line on the console output. |
|
sure, see the following: nglangsvc.log |
|
Strange, the log looks okay. Did you ever observe this error before the latest version of the extension? This might be related to #594. |
|
@blubberbo Do you mind turning on verbose logging and capture the log file again? |
kyliau
changed the title
|
I got similar error: |
[Info - 7:20:22 PM] Angular language server process ID: 787 RangeError: Maximum call stack size exceeded and |
|
Thank you @andrius-pra for the repro. I was able to replicate the crash on my machine. It looks like it was trying to recursively resolve the symbols from the same file. |
To the create symbols of a module, the static symbol resolver first gets all the symbols loaded in the module by an export statement. For `export * from './module'`-like statements, all symbols from `./module` must be loaded. In cases where the exporting module is actually the same module that the export statement is in, this causes an unbounded recursive resolution of the same module. Exports of the same module are not needed, as their symbols will be resolved when the symbols in the module metadata's `metadata` key is explored. This commit resolves the unbounded recursion by loading exporting modules only if they differ from the module currently being resolved. Closes angular/vscode-ng-language-service#593
ayazhafiz
added
the
lib
To create the symbols of a module, the static symbol resolver first gets all the symbols loaded in the module by an export statement. For `export * from './module'`-like statements, all symbols from `./module` must be loaded. In cases where the exporting module is actually the same module that the export statement is in, this causes an unbounded recursive resolution of the same module. Exports of the same module are not needed, as their symbols will be resolved when the symbols in the module metadata's `metadata` key is explored. This commit resolves the unbounded recursion by loading exporting modules only if they differ from the module currently being resolved. Closes angular/vscode-ng-language-service#593
To create the symbols of a module, the static symbol resolver first gets all the symbols loaded in the module by an export statement. For `export * from './module'`-like statements, all symbols from `./module` must be loaded. In cases where the exporting module is actually the same module that the export statement is in, this causes an unbounded recursive resolution of the same module. Exports of the same module are not needed, as their symbols will be resolved when the symbols in the module metadata's `metadata` key is explored. This commit resolves the unbounded recursion by loading exporting modules only if they differ from the module currently being resolved. Closes angular/vscode-ng-language-service#593
To create the symbols of a module, the static symbol resolver first gets all the symbols loaded in the module by an export statement. For `export * from './module'`-like statements, all symbols from `./module` must be loaded. In cases where the exporting module is actually the same module that the export statement is in, this causes an unbounded recursive resolution of the same module. Exports of the same module are not needed, as their symbols will be resolved when the symbols in the module metadata's `metadata` key is explored. This commit resolves the unbounded recursion by loading exporting modules only if they differ from the module currently being resolved. Closes angular/vscode-ng-language-service#593
…35262) To create the symbols of a module, the static symbol resolver first gets all the symbols loaded in the module by an export statement. For `export * from './module'`-like statements, all symbols from `./module` must be loaded. In cases where the exporting module is actually the same module that the export statement is in, this causes an unbounded recursive resolution of the same module. Exports of the same module are not needed, as their symbols will be resolved when the symbols in the module metadata's `metadata` key is explored. This commit resolves the unbounded recursion by loading exporting modules only if they differ from the module currently being resolved. Closes angular/vscode-ng-language-service#593 PR Close #35262
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
I am getting the
The Angular Language Service server crashed 5 times in the last 3 minutes. The server will not be restarted.message in my vscode.The output is the following:
The text was updated successfully, but these errors were encountered: