Skip to content
This repository has been archived by the owner on Oct 29, 2023. It is now read-only.

build(deps): update dependency highlight.js to v10.1.2 [security] #2195

Merged
merged 1 commit into from
Nov 24, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 24, 2020

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
highlight.js (source) 10.0.0 -> 10.1.2 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-26237

Impact

Affected versions of this package are vulnerable to Prototype Pollution. A malicious HTML code block can be crafted that will result in prototype pollution of the base object's prototype during highlighting. If you allow users to insert custom HTML code blocks into your page/app via parsing Markdown code blocks (or similar) and do not filter the language names the user can provide you may be vulnerable.

The pollution should just be harmless data but this can cause problems for applications not expecting these properties to exist and can result in strange behavior or application crashes, i.e. a potential DOS vector.

If your website or application does not render user provided data it should be unaffected.

Patches

Versions 9.18.2 and 10.1.2 and newer include fixes for this vulnerability. If you are using version 7 or 8 you are encouraged to upgrade to a newer release.

Workarounds

Patch your library

Manually patch your library to create null objects for both languages and aliases:

const HLJS = function(hljs) {
  // ...
  var languages = Object.create(null);
  var aliases = Object.create(null);

Filter out bad data from end users

Filter the language names that users are allowed to inject into your HTML to guarantee they are valid.

References

For more information

If you have any questions or comments about this advisory:


Release Notes

highlightjs/highlight.js

v10.1.2

Compare Source

Fixes:

  • fix(night) Prevent object prototype values from being returned by getLanguage (#​2636) night

v10.1.1

Compare Source

Fixes:

v10.1.0

Compare Source

New themes:

Parser Engine:

Deprecations:

Language Improvements:

v10.0.3

Compare Source

v10.0.2

Compare Source

Brower build:

Parser Engine Changes:

v10.0.1

Compare Source

Parser Engine Changes:


Renovate configuration

📅 Schedule: "" in timezone America/Tijuana.

🚦 Automerge: Enabled.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@google-cla google-cla bot added the cla: yes label Nov 24, 2020
@renovate renovate bot merged commit 09741d8 into master Nov 24, 2020
@renovate renovate bot deleted the renovate/npm-highlight.js-vulnerability branch November 24, 2020 23:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant