Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(language-service): Allow language service diagnostics to be ignored #57675

Closed
wants to merge 1 commit into from
Closed

refactor(language-service): Allow language service diagnostics to be ignored #57675

wants to merge 1 commit into from

Conversation

dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Sep 5, 2024

Add a check to the language service that ignores specified diagnostic codes.

This can be patched in g3 as needed, to ignore codes that are not relevant for g3 (or otherwise not compatible).

@dylhunn dylhunn added action: review The PR is still awaiting reviews from at least one requested reviewer area: language-service Issues related to Angular's VS Code language service target: minor This PR is targeted for the next minor release labels Sep 5, 2024
@dylhunn dylhunn requested a review from atscott September 5, 2024 17:17
@ngbot ngbot bot modified the milestone: Backlog Sep 5, 2024
@dylhunn dylhunn requested a review from clydin September 5, 2024 17:18
atscott
atscott approved these changes Sep 5, 2024
View reviewed changes
Copy link
Contributor

@atscott atscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: angular/vscode-ng-language-service#1243

@dylhunn
refactor(language-service): Allow language service diagnostics to be …
b51d7cf 
…ignored

Add a check to the language service that ignores specified diagnostic codes. This will be useful in g3.

The codes to ignore are exposed as part of the PluginConfig.

Fixes github.com/angular/vscode-ng-language-service/issues/1243
@dylhunn dylhunn added action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Sep 5, 2024
@dylhunn
Copy link
Contributor Author

dylhunn commented Sep 5, 2024

Caretaker: g3 is good to go

@thePunderWoman
Copy link
Contributor

This PR was merged into the repository by commit f063a75.

The changes were merged into the following branches: main

dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 6, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
4bd14ba 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
@dylhunn dylhunn mentioned this pull request Sep 6, 2024
Merged
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 6, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
6eb3d74 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
8d2577a 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
1ad55e8 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
7a476f5 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
5ab4b59 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
e327060 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
c25356d 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
dylhunn added a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 9, 2024
@dylhunn
feat(language-service): Allow specific diagnostics to be suppressed
ed84dc6 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
atscott pushed a commit to dylhunn/vscode-ng-language-service that referenced this pull request Sep 10, 2024
@dylhunn @atscott
feat(language-service): Allow specific diagnostics to be suppressed
523ae17 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes angular#1243
atscott pushed a commit to angular/vscode-ng-language-service that referenced this pull request Sep 10, 2024
@dylhunn @atscott
feat(language-service): Allow specific diagnostics to be suppressed
7c13306 
Allow the language service plugin to pass diagnostic codes that should be ignored via the PluginConfig.

This change corresponds to PR angular/angular#57675.

Fixes #1243
and-oli pushed a commit to and-oli/angular that referenced this pull request Sep 30, 2024
@dylhunn @and-oli
refactor(language-service): Allow language service diagnostics to be …
64b95fd 
…ignored (angular#57675)

Add a check to the language service that ignores specified diagnostic codes. This will be useful in g3.

The codes to ignore are exposed as part of the PluginConfig.

Fixes github.com/angular/vscode-ng-language-service/issues/1243

PR Close angular#57675
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

@atscott atscott atscott approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: language-service Issues related to Angular's VS Code language service merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
4 participants
@dylhunn @thePunderWoman @atscott @clydin