This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngMock): return immediately from mock $interval.cancel() when no promise argument is supplied #6103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for a possible cause of issue #6099.
Calling
$interval.cancel()
without supplying the expected argument would cause a TypeError. There was a test for this but it was incomplete because it did not setup the instance of $interval with any repeated functions, so the function passed toforEach
in which the error is thrown is never executed. The test failed when a repeated task was added.This pull requests prevents the runtime exception by returning from
cancel()
immediately if no promise is supplied (doesn't even get to the loop) and improves the test by setting up a repeating task as the other tests do.