This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix(select): placeholder (empty option) is lost in IE9 #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a check inside render for select elements with ngOptions, which compares the selected property of an element with it's desired state. In instances where no element should be selected, this resulted in the first option in the select element having it's selected attribute set from undefined to false. In most browsers, this has the effect of displaying the first item in the list. In IE9 however, this causes the select to display nothing. In other browsers this would still cause unnecessary changes in selected state, but no visible issue would manifest. Closes angular#2150, angular#1826
PR Checklist (Minor Bugfix)
|
|
The CLA has been signed and submitted to [email protected] on Mon, Mar 4, 2013 at 2:50 PM. |
|
@mhevery Could you clarify the remaining checklist items please? The PR is marked good to merge according to Travis and I'm not sure how to trigger a build of it on Jenkins. Is there anything else which needs to be completed? |
|
@chad-configit don't worry about tests on Jenkins, this is something we trigger on our end just before merging to check if tests pass on all supported browsers. I've also marked Travis state accordingly. |
|
Unfortunately I've just discovered a side effect to this PR; deselection in a multi-select isn't working as it should. I shall recommit with the correction. |
ghost
mentioned this pull request
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a check inside render for select elements with ngOptions, which compares the selected property of an element with it's desired state.
In instances where no element should be selected, this resulted in the first option in the select element having it's selected attribute set from undefined to false.
In most browsers, this has the effect of displaying the first item in the list. In IE9 however, this causes the select to display nothing.
In other browsers this would still cause unnecessary changes in selected state, but no visible issue would manifest.
Closes #2150, #1826