Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

bug-fix for ng-list directive #1839

Closed
wants to merge 2 commits into from
Closed

Conversation

ashishgithub
Copy link

Issue : ng-list directive overrides user specified separator by comma separator.
Resolution : Corrected the code of ng-list directive.

@ashishgithub
Copy link
Author

I am not able to understand the cause of build failure.
Can anyone throwsome light on it ?

@pkozlowski-opensource
Copy link
Member

@ashishgithub Travis-CI is unstable at the moment, we don't know what is the root cause as of now. So I don't think that the build failure is linked to your change.

Having said this, I had a look at your pull request and it will need tests before it can be considered for merging. Also you will need amend a commit message to sign the CLA. Details are here: http://docs.angularjs.org/misc/contribute

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants