This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Apply $last to the array after properties starting with $ have been filtered out #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ties beginning with $
…tered out If the $last property is calculated from the original collectionLength on an object and properties starting with $ were filtered out, then $last is never applied and $middle is applied erroniously. This fix uses the length of the filtered array instead. Fixes angular#1789
|
I refactored your change a bit - it's better to just calculate arrayLength instead of collectionLength after the object is converted to an array. I also extracted the test into a isolated spec. putting too much stuff into a single spec, makes the spec too complex and hard to understand when a failure occurs. lastly I fixed up your commit message a bit. the changes landed as 7e74601 thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1789