Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

ng-animate 1.2.14 bug on android #6526

Closed
AlmogBaku opened this issue Mar 3, 2014 · 2 comments
Closed

ng-animate 1.2.14 bug on android #6526

AlmogBaku opened this issue Mar 3, 2014 · 2 comments

Comments

@AlmogBaku
Copy link

TESTED ON PHONEGAP

When using 1.2.14 the view is stuck/not shown.
this bug is started since this version(not happened in 1.2.13)

@Narretz
Copy link
Contributor

Narretz commented Mar 3, 2014

Hey, thanks for reporting. It would help very much if you could provide a minimal reproduction of the problem on http://plnkr.co/

@Traxmaxx
Copy link
Contributor

Traxmaxx commented Mar 4, 2014

I can confirm the issue on Android 4.3.
RAFProvider is checking for cancelAnimationFrame and webkitCancelAnimationFrame ( see

var cancelAnimationFrame = $window.cancelAnimationFrame ||
)
For Android 4.3 we need to check for webkitCancelRequestAnimationFrame too.

Changing the code to the following works for me:

var cancelAnimationFrame = $window.cancelAnimationFrame ||
 $window.webkitCancelAnimationFrame || 
 $window.webkitCancelRequestAnimationFrame;

Traxmaxx added a commit to Traxmaxx/angular.js that referenced this issue Mar 4, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
@tbosch tbosch self-assigned this Mar 6, 2014
@tbosch tbosch added this to the 1.3.x milestone Mar 6, 2014
@tbosch tbosch removed their assignment Mar 6, 2014
Traxmaxx added a commit to Traxmaxx/angular.js that referenced this issue Mar 6, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
Traxmaxx added a commit to Traxmaxx/angular.js that referenced this issue Mar 6, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
Traxmaxx added a commit to Traxmaxx/angular.js that referenced this issue Mar 18, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
Traxmaxx added a commit to Traxmaxx/angular.js that referenced this issue Mar 18, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
matsko pushed a commit to matsko/angular.js that referenced this issue Mar 19, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
matsko pushed a commit to matsko/angular.js that referenced this issue Mar 19, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes angular#6526
@matsko matsko closed this as completed in c839f78 Mar 19, 2014
matsko pushed a commit that referenced this issue Mar 19, 2014
Android 4.3 only supports webkitCancelRequestAnimationFrame.

Closes #6526
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.