-
Notifications
You must be signed in to change notification settings - Fork 27.5k
TypeError with ngAnimate #6205
Comments
@matsko can you look into this please? |
This happens when an element with e.g. This is because here, var node = extractElementNode(element); |
…gAnimate when use ng-if on ng-repeat fix angular#6205
I would have I will make a pull request for that if you prefer my approach. Please let me know. |
Method returns a html node or undefined not array, i can check if node === undefined, but i see no reason. |
You're right, sorry. I confused it with something else. The method returns HTML node elements. |
+1 |
…ncelChildAnimations When element with ng-repeat has an ng-if directive and user try to remove any item from array used for ng-repeat, he gets error "TypeError Cannot call method 'querySelectorAll' of undefined". This happens because in method cancelChildAnimations of ngAnimate directive not checked value returned from extractElementNode(element) method. Fix add a validation for result of extractElementNode(element) method. Closes angular#6205
…ncelChildAnimations When element with ng-repeat has an ng-if directive and user try to remove any item from array used for ng-repeat, he gets error "TypeError Cannot call method 'querySelectorAll' of undefined". This happens because in method cancelChildAnimations of ngAnimate directive not checked value returned from extractElementNode(element) method. Fix add a validation for result of extractElementNode(element) method. Closes angular#6205
…ncelChildAnimations When element with ng-repeat has an ng-if directive and user try to remove any item from array used for ng-repeat, he gets error "TypeError Cannot call method 'querySelectorAll' of undefined". This happens because in method cancelChildAnimations of ngAnimate directive not checked value returned from extractElementNode(element) method. Fix add a validation for result of extractElementNode(element) method. Closes angular#6205
…ncelChildAnimations When an element containing both ng-repeat and ng-if directives attempts to remove any items from the repeat collection, the following error is thrown: "TypeError Cannot call method 'querySelectorAll' of undefined". This happens because the cancelChildAnimations code naively belives that the jqLite object always has an element node within it. The fix in this commit addresses to securely check to see if a node was properly extracted before any child elements are inspected. Closes angular#6205
Landed as c914cd9 |
Hi, I'm using the latest Angular 1.2 head at Google (I'm lahiri@). I occasionally get the following error when I've injected ngAnimate into my app -- without actually using it. The ng-animate directive isn't invoked anywhere, and I don't have any CSS transitions. Removing ngAnimate from my app's module dependencies gets rid of the error.
The text was updated successfully, but these errors were encountered: