-
Notifications
You must be signed in to change notification settings - Fork 27.5k
Doesn't fire "input" event on IE10 with Japanese IME is enabled #6058
Comments
Does it fire compositionend? I wonder if it would make sense to trigger the listener on compositionend. Do me a favour and try adding a call to the listener function at the end of this function |
I can take this since I have a machine with IE10 and MS's Japanese IME. |
@caitp Yes, compositionend works without incident. The event called after typed return key (String is established) but listener function isn't called so it seems that ctrl.$setViewValue doesn't executed. |
What I mean is, does calling the listener function on compositionend solve this for you? IIRC we were doing this a while ago, or maybe that change never merged, but it seemed to fix some other similar issues on android. I am sure we had a good reason not to do it, but it's a possible solution. @clkao wrote the other patches regarding composition and probably knows more about it than me |
@caitp Yes, I will be solved. The listener function would be called twice only just adding if browser is supporting "input" event except IE10 on currency code. Of course, I think that fix is not problem because already comparing old and new string. |
@tsuyoshizawa can you create an PR calling listener on |
#5433 was doing exactly this, but I can't recall why it was decided against. Should be easy to rebase the patch and try it, though |
@caitp oh we probably decided it was just chrome on android being broken, as people also wanted the model updated during autocomplate-enabled IME in english, so we went with the fix disabling it on android altogether. How that this is manifesting on IE10... |
The PR works well to me. Thank you. |
@caitp LGTM |
Because of a4e6d96, model is not updated on input/change between the compositionstart and compositionend events. Unfortunately, the compositionend event does not always happen prior to an input/change event. This changeset calls the listener function to update the model after a compositionend event is received. Closes angular#6058 Closes angular#5433
(I repost my comment from the #6656) Hello, I am web developer in Korea and I have noticed the same issue. Important fact: I made a keyup function via jQuery, it works well! I have recorded a video to show the issue on IE11 (Korean version): https://www.screenr.com/XGcN Plunker: http://plnkr.co/edit/WaZvP4ivhIaPxYRmKjeF?p=preview |
@Luien you must be talking about my jQuery part. You're right, my purpose was not to make a workaround, just to show how the Keyboard events differ between JQuery and AngularJS concerning Korean characters. |
On IE10, "input" event doesn't fire while typing by Japanese, so model isn't bound application can't get the value. (I use ng-model on input text element.)
https://github.com/angular/angular.js/blob/v1.2.10/src/ng/directive/input.js#L447
The text was updated successfully, but these errors were encountered: