when clicking on SVG diagrams with links I get: TypeError: Object #<SVGAnimatedString> has no method 'indexOf'

[jstrachan]

pull request on its way...

[snostorm]

+1, got this error today myself

[IgorMinar]

@jstrachan please submit a plunker/jsfiddle or PR with a test. thanks!

[jeffbcross]

@jstrachan is your pull request still in progress? Would it be too much trouble to put together a plunker demonstrating the issue?

[jstrachan]

@jeffbcross phew - managed to recreate it in a plunker
http://plnkr.co/edit/l09WSkJt0B3s6kROeKal?p=preview

basically if you use $location then have an SVG diagram with any elements inside and you click on the SVG diagram it generates the TypeError in the JavaScript console

[jstrachan]

@jeffbcross incidentally the HTML is a little bigger than is required ;) e.g. you can ignore the <style> element and the details of the tree; other than just its a shape with an element inside - then its the presence of $location in the controller that causes the bug

[jeffbcross]

Thanks! I was able to reproduce the issue. I'm a little slammed this week, but hopefully I can take a look at a fix soon (or review a PR if you submit one).

[caitp]

I think the issue here is the htmlAnchorDirective (https://github.com/angular/angular.js/blob/master/src/ng/directive/a.js) --- It might be possible to detect that it's an svg element (does the node get an appropriate namespace?) and adjust its behaviour. I might run some tests to see real quick, but I'm not totally sure --- actually, it probably isn't even related to that directive, hmm. well, I'll take a quick look, yeah it's in the location click handler.

So basically, we get an SVGAnimatedString, which gives us "baseVal" and "animVal", where "baseVal" is the value before applying transformations, and "animVal" is either equal to "baseVal" if not animated, or the current transformed state.

I really can't decide if it's more appropriate to use animVal or baseVal there! But I guess it's important to get the proper value out of it.

Or maybe just abort if href is an SVGAnimatedString?

Anyways, this is kind of painful because the SVGAnimatedString doesn't give us the absolute href as parsed by the browser. Maybe it would be better to just skip handling these SVGAElement links all together.

[caitp]

Well there's my shot at it, maybe it could/should be handled differently. Let me know